Messages in this thread | | | Subject | Re: [PATCH 01/14] memory: ti-emif-sram: Add resume function to recopy sram code | From | Santosh Shilimkar <> | Date | Wed, 23 May 2018 09:42:54 -0700 |
| |
On 5/23/2018 1:47 AM, Keerthy wrote: > > > On Monday 16 April 2018 03:59 PM, Keerthy wrote: >> [..]
>>> Instead of this indirect method , why can't just check the previous >>> deep sleep mode and based on that do copy or not. EMIF power status >>> register should have something like that ? >> >> I will check if we have a register that tells the previous state of sram. > > Unfortunately i do not see any such register for knowing SRAM previous > state in am43 TRM and hence this indirect way of knowing. > OK.
> >> >>> >>> Another minor point is even though there is nothing to do in suspend, >>> might be good to have a callback with comment that nothing to do with >>> some explanation why not. Don't have strong preference but may for >>> better readability. > > I can add a blank suspend call with comment > > "The contents are already present in DDR hence no need to explicitly save" > > The comment in resume function pretty much explains the above. So let me > know if i need to add the suspend callback. > Please add the empty suspend callback with comment.
Regards, Santosh
| |