Messages in this thread | | | Subject | Re: [PATCH v2 2/2] kasan: fix memory hotplug during boot | From | David Hildenbrand <> | Date | Wed, 23 May 2018 13:52:03 +0200 |
| |
On 23.05.2018 11:59, Andrey Ryabinin wrote: > > > On 05/23/2018 12:07 AM, Andrew Morton wrote: >> On Tue, 22 May 2018 22:50:12 +0300 Andrey Ryabinin <aryabinin@virtuozzo.com> wrote: >> >>> >>> >>> On 05/22/2018 07:36 PM, David Hildenbrand wrote: >>>> On 22.05.2018 18:26, Andrey Ryabinin wrote: >>>>> >>>>> >>>>> On 05/22/2018 01:07 PM, David Hildenbrand wrote: >>>>>> Using module_init() is wrong. E.g. ACPI adds and onlines memory before >>>>>> our memory notifier gets registered. >>>>>> >>>>>> This makes sure that ACPI memory detected during boot up will not >>>>>> result in a kernel crash. >>>>>> >>>>>> Easily reproducable with QEMU, just specify a DIMM when starting up. >>>>> >>>>> reproducible >>>>>> >>>>>> Signed-off-by: David Hildenbrand <david@redhat.com> >>>>>> --- >>>>> >>>>> Fixes: fa69b5989bb0 ("mm/kasan: add support for memory hotplug") >>>>> Acked-by: Andrey Ryabinin <aryabinin@virtuozzo.com> >>>>> Cc: <stable@vger.kernel.org> >>>> >>>> Think this even dates back to: >>>> >>>> 786a8959912e ("kasan: disable memory hotplug") >>>> >>> >>> Indeed. >> >> Is a backport to -stable justified for either of these patches? >> > > I don't see any reasons to not backport these. > The first one fixes failure to online memory, why it shouldn't be fixed in -stable? > The second one is fixes boot crash, it's definitely stable material IMO. >
Agreed, at least the second one should be cc stable, as I can reproduce it with a simple QEMU command.
--
Thanks,
David / dhildenb
| |