Messages in this thread | | | Subject | Re: [PATCHv3 2/2] x86/vdso: Add build salt to the vDSO | From | Laura Abbott <> | Date | Wed, 23 May 2018 18:36:08 -0700 |
| |
On 05/23/2018 05:06 PM, Linus Torvalds wrote: > > > On Wed, May 23, 2018, 17:01 Andy Lutomirski <luto@amacapital.net <mailto:luto@amacapital.net>> wrote: > > > I don’t know whether I’m missing something obvious, but can’t this be in C? > > > Yes, but I thought Laura wanted to limit it to linker file tricks (this thread has gone on for so long that I've forgotten the details of why). > > Linus > >
So we have to update the kernel and every module and the easiest way to do that was the linker script. I was assuming I'd just use the same approach for the vDSO but you're right that there's no reason we can't apply a different technique. I notice there's already a vdso-note.S which adds LINUX_VERSION_CODE as a note. This doesn't include the extra version so it doesn't quite meet our needs. There's no reason why we can't throw something else in there for good measure.
Thanks, Laura
| |