Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Tue, 22 May 2018 09:48:06 +0200 | Subject | Re: [PATCH 3/3] arm64: dts: renesas: r8a7795: add ccree binding |
| |
Hi Gilad,
On Mon, May 21, 2018 at 3:43 PM, Gilad Ben-Yossef <gilad@benyossef.com> wrote: > On Thu, May 17, 2018 at 1:16 PM, Geert Uytterhoeven > <geert@linux-m68k.org> wrote: >> Indeed. From a quick glance, it looks like drivers/crypto/ccree/cc_driver.c >> does not distinguish between the absence of the clock property, and an >> actual error in getting the clock, and never considers any error a failure >> (incl. -PROBE_DEFER). >> >> As of_clk_get() returns -ENOENT for both a missing clock property and a >> missing clock, you should use (devm_)clk_get() instead, and distinguish >> between NULL (no clock property) and IS_ERR() (actual failure -> abort). > > I was trying to do as you suggested but I didn't quite get what is the > dev_id (2nd) parameter to devm_clk_get parameter is supposed to be.
It's the (optional) name of the clock, helpful in case there is more than one. In your case, NULL is fine.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |