lkml.org 
[lkml]   [2018]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v6 2/6] dt-bindings: Add the rzn1-clocks.h file
    Hi Michel,

    On Tue, May 22, 2018 at 12:01 PM, Michel Pollet
    <michel.pollet@bp.renesas.com> wrote:
    > This adds the constants necessary to use the renesas,rzn1-clocks driver.
    >
    > Signed-off-by: Michel Pollet <michel.pollet@bp.renesas.com>

    Thanks for your patch!

    > ---
    > include/dt-bindings/clock/rzn1-clocks.h | 187 ++++++++++++++++++++++++++++++++
    > 1 file changed, 187 insertions(+)
    > create mode 100644 include/dt-bindings/clock/rzn1-clocks.h
    >
    > diff --git a/include/dt-bindings/clock/rzn1-clocks.h b/include/dt-bindings/clock/rzn1-clocks.h
    > new file mode 100644
    > index 0000000..8a73db2
    > --- /dev/null
    > +++ b/include/dt-bindings/clock/rzn1-clocks.h

    Given this is part of the DT ABI, and there exist multiple different RZ/N1
    SoCs (and there are probably planned more), I wouldn't call this header
    file "rzn1-clocks.h", but e.g. "r9a06g032-clocks.h".

    > @@ -0,0 +1,187 @@
    > +/* SPDX-License-Identifier: GPL-2.0 */
    > +/*
    > + * RZ/N1 clock IDs
    > + *
    > + * Copyright (C) 2018 Renesas Electronics Europe Limited
    > + *
    > + * Michel Pollet <michel.pollet@bp.renesas.com>, <buserror@gmail.com>
    > + * Derived from zx-reboot.c
    > + */
    > +
    > +#ifndef __DT_BINDINGS_RZN1_CLOCK_H__
    > +#define __DT_BINDINGS_RZN1_CLOCK_H__
    > +
    > +#define RZN1_CLKOUT 0

    Similar for the RZN1 prefix.

    I'll look at the actual list of clocks later...

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    \
     
     \ /
      Last update: 2018-05-22 20:44    [W:4.116 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site