Messages in this thread | | | Date | Tue, 22 May 2018 18:16:22 +0200 | From | Sebastian Reichel <> | Subject | Re: [PATCH 18/33] power: supply: use match_string() helper |
| |
Hi Andy,
On Tue, May 22, 2018 at 12:58:14AM +0300, Andy Shevchenko wrote: > On Mon, May 21, 2018 at 2:57 PM, Yisheng Xie <xieyisheng1@huawei.com> wrote: > > match_string() returns the index of an array for a matching string, > > which can be used intead of open coded variant. > > > > This doesn't make code looks better anyhow. I even think it makes it > worse to read. That's why I dropped my version of the change (and yes, > I missed the type conversion which looks here just ugly). > > Sebastian, if my opinion makes any difference here, I would say > NAK to this one.
I agree.
-- Sebastian [unhandled content-type:application/pgp-signature] | |