lkml.org 
[lkml]   [2018]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v6 17/28] x86/asm: use SYM_INNER_LABEL instead of GLOBAL
From
Date
On 05/18/2018, 09:41 PM, Andy Lutomirski wrote:
> On Fri, May 18, 2018 at 2:17 AM Jiri Slaby <jslaby@suse.cz> wrote:
>
>> GLOBAL had several meanings and is going away. In this patch, convert
>> all the inner function labels marked with GLOBAL to use SYM_INNER_LABEL
>> instead.
>
>> Note that retint_user needs not be global, perhaps since commit
>> 2ec67971facc ("x86/entry/64/compat: Remove most of the fast system call
>> machinery"), where entry_64_compat's caller was removed. So mark the
>> label as LOCAL.
>
>
>> -GLOBAL(entry_SYSCALL_64_after_hwframe)
>> +SYM_INNER_LABEL(entry_SYSCALL_64_after_hwframe, SYM_L_GLOBAL)
>
> I've missed all the context here. I agree that GLOBAL is misleading, and
> "inner label" is nice. But this is a rather wordy macro. Would:
>
> INNER_LABEL_GLOBAL(name)
>
> be better? (With just INNER_LABEL(name) for the local version?)

All the macros have SYM_ prefix. Other macros look like this:
SYM_FUNC_START_LOCAL(name)
SYM_FUNC_START(name)

So I can make the inner one:
SYM_INNER_LABEL_LOCAL(name)
SYM_INNER_LABEL(name)

to be consistent with the rest, if that is OK?

thanks,
--
js
suse labs

\
 
 \ /
  Last update: 2018-05-21 09:14    [W:0.038 / U:4.368 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site