lkml.org 
[lkml]   [2018]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 07/33] iwlwifi: mvm: use match_string() helper
    On Mon, 2018-05-21 at 19:57 +0800, Yisheng Xie wrote:
    > match_string() returns the index of an array for a matching string,
    > which can be used intead of open coded variant.
    >
    > Cc: Kalle Valo <kvalo@codeaurora.org>
    > Cc: Intel Linux Wireless <linuxwifi@intel.com>
    > Cc: Johannes Berg <johannes.berg@intel.com>
    > Cc: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
    > Cc: linux-wireless@vger.kernel.org
    > Cc: netdev@vger.kernel.org
    > Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
    > ---
    > drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c | 11 +++--------
    > 1 file changed, 3 insertions(+), 8 deletions(-)
    >
    > diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c
    > b/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c
    > index 0e6401c..e8249a6 100644
    > --- a/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c
    > +++ b/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c
    > @@ -671,14 +671,9 @@ static ssize_t iwl_dbgfs_bt_cmd_read(struct file
    > *file, char __user *user_buf,
    > };
    > int ret, bt_force_ant_mode;
    >
    > - for (bt_force_ant_mode = 0;
    > - bt_force_ant_mode < ARRAY_SIZE(modes_str);
    > - bt_force_ant_mode++) {
    > - if (!strcmp(buf, modes_str[bt_force_ant_mode]))
    > - break;
    > - }
    > -
    > - if (bt_force_ant_mode >= ARRAY_SIZE(modes_str))
    > + bt_force_ant_mode = match_string(modes_str,
    > + ARRAY_SIZE(modes_str),
    > buf);
    > + if (bt_force_ant_mode < 0)
    > return -EINVAL;
    >
    > ret = 0;

    Looks fine, I'll push this to our internal tree for review and take a
    closer look at what the match_string() function does exactly.

    Thanks for the patch.

    --
    Cheers,
    Luca.

    \
     
     \ /
      Last update: 2018-05-21 22:13    [W:4.202 / U:0.176 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site