lkml.org 
[lkml]   [2018]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 07/33] iwlwifi: mvm: use match_string() helper
    From
    Date
    Hi Andy,

    On 2018/5/22 5:43, Andy Shevchenko wrote:
    > On Mon, May 21, 2018 at 2:57 PM, Yisheng Xie <xieyisheng1@huawei.com> wrote:
    >> match_string() returns the index of an array for a matching string,
    >> which can be used intead of open coded variant.
    >
    >> int ret, bt_force_ant_mode;
    >>
    >> - for (bt_force_ant_mode = 0;
    >> - bt_force_ant_mode < ARRAY_SIZE(modes_str);
    >> - bt_force_ant_mode++) {
    >> - if (!strcmp(buf, modes_str[bt_force_ant_mode]))
    >> - break;
    >> - }
    >> -
    >> - if (bt_force_ant_mode >= ARRAY_SIZE(modes_str))
    >
    >> + bt_force_ant_mode = match_string(modes_str,
    >> + ARRAY_SIZE(modes_str), buf);
    >
    > One line?

    hmm, if use ret instead it will no over 80 chars.

    >
    >> + if (bt_force_ant_mode < 0)
    >> return -EINVAL;
    >
    > I would rather use
    >
    > ret = match_string();
    > if (ret < 0)
    > return ret;
    >
    > bt_force_... = ret;
    >
    > But it's up tu Loca.

    OK, I will change it if Loca agree your opinion.

    Thanks
    Yisheng
    >
    >>
    >> ret = 0;
    >
    >
    >

    \
     
     \ /
      Last update: 2018-05-22 05:31    [W:6.954 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site