| From | Andy Shevchenko <> | Date | Tue, 22 May 2018 01:25:39 +0300 | Subject | Re: [PATCH 32/33] ASoC: max98095: use match_string() helper |
| |
On Mon, May 21, 2018 at 2:58 PM, Yisheng Xie <xieyisheng1@huawei.com> wrote: > match_string() returns the index of an array for a matching string, > which can be used intead of open coded variant.
> + int ret = match_string(bq_mode_name, ARRAY_SIZE(bq_mode_name), name);
Rather split and move an assignment to the line before 'if'.
> > /* Shouldn't happen */
> + if (ret < 0) > + dev_err(component->dev, "Bad biquad channel name '%s'\n", name); > + return ret; > }
-- With Best Regards, Andy Shevchenko
|