lkml.org 
[lkml]   [2018]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 13/14] net: sched: use unique idr insert function in unlocked actions
    On Sun, May 20, 2018 at 1:20 AM, Marcelo Ricardo Leitner
    <marcelo.leitner@gmail.com> wrote:
    > On Mon, May 14, 2018 at 05:27:14PM +0300, Vlad Buslov wrote:
    >> Substitute calls to action insert function with calls to action insert
    >> unique function that warns if insertion overwrites index in idr.
    >
    > I know this patch may be gone on V2, but a general comment, please use
    > the function names themselves instead of a textualized version. I.e.,
    > s/action insert unique/tcf_idr_insert_unique/

    disagree. While doing reviews I found out that if I ask the developer
    to use higher
    level / descriptive language and specifically to avoid putting
    variable / function names in
    patch titles and change logs, the quality gets ++ big time, vs if the
    developer is allowed to say

    net/mlx5: Changed add_vovo_bobo()

    Added variable do_it_right to add_vovo_bobo(), now we are terribly good.

    \
     
     \ /
      Last update: 2018-05-20 23:13    [W:3.580 / U:0.932 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site