lkml.org 
[lkml]   [2018]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings
    From
    Date
    On 05/02/2018 09:37 AM, Doug Anderson wrote:
    > On Fri, Apr 13, 2018 at 7:50 PM, David Collins <collinsd@codeaurora.org> wrote:
    >> +- vdd_l26-supply
    >> +- vdd_lvs1_lvs2-supply
    >> +- vdd_lvs1_lvs2-supply
    >> + Usage: optional (PM8998 only)
    >> + Value type: <phandle>
    >> + Definition: phandle of the parent supply regulator of one or more of the
    >> + regulators for this PMIC.
    >
    > One small additional nit here is that "vdd_lvs1_lvs2-supply" is listed twice.

    I'll remove the duplicate.


    > Also on the schematics (and in the PM8998 datasheet) I have this is
    > "VIN_LVS_1_2". It seems like you should be consistent here and call
    > this "vin-lvs-1-2-supply".

    I was trying to keep the naming consistent within device tree binding
    documentation for LVS vs LDO and SMPS (e.g. 'vdd' vs 'vin' prefix). I
    suppose that I can change this to match the hardware documentation pin
    name. I can also change '_' to '-' in the supply names if that is preferred.

    Take care,
    David

    --
    The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
    a Linux Foundation Collaborative Project

    \
     
     \ /
      Last update: 2018-05-03 09:44    [W:3.886 / U:0.388 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site