lkml.org 
[lkml]   [2018]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Input: serio - add writing multiple bytes at once
From
Date
Hi Dmitry,

On 30.04.2018 at 23:20, Dmitry Torokhov wrote:
> Hi David,
>
> On Mon, Apr 30, 2018 at 11:03:24AM +0200, David Engraf wrote:
>> The current version only supports forwarding a single byte to the tty
>> layer.
>>
>> This patch adds serio_write_length() to allow a serport driver writing
>> multiple bytes at once. The patch also includes a fallback to
>> serio_write_length() when a driver did not register a single byte function.
>
> Without users I do not see point for this API.

Here is an incomplete list of drivers calling serio_write() in a loop:

- drivers/media/usb/rainshadow-cec/rainshadow-cec.c
- drivers/input/serio/serio_raw.c
- drivers/input/touchscreen/elo.c

I can simplify these drivers by using serio_write_length() if you want
to have some users for the new API.

Best regards
- David

\
 
 \ /
  Last update: 2018-05-02 09:08    [W:0.046 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site