Messages in this thread | | | Date | Wed, 02 May 2018 09:00:04 -0600 | From | "Jan Beulich" <> | Subject | Re: [Xen-devel] [PATCH 2/4] xen/PVH: Use proper CS selector in long mode |
| |
>>> On 02.05.18 at 16:57, <boris.ostrovsky@oracle.com> wrote: > On 05/02/2018 04:05 AM, Jan Beulich wrote: >>>>> On 30.04.18 at 18:23, <boris.ostrovsky@oracle.com> wrote: >>> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> >> Reviewed-by: Jan Beulich <jbeulich@suse.com> >> >> But to understand why things have been working nevertheless it would >> have been nice if the commit message wasn't empty, but instead said >> something like "The two happen to be identical on 64-bit." > > > Why do you think they are identical? __KERNEL_CS points to entry#12 > (which we don't specify in PVH GDT) while __BOOT_CS is the second entry > (which we do create).
That's 32-bit's __KERNEL_CS. If the two weren't identical, the ljmp you adjust would never have worked afaict.
Jan
| |