lkml.org 
[lkml]   [2018]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/5] acpi/processor: Fix the return value of acpi_processor_ids_walk()
On Tue, 20 Mar 2018, Dou Liyang wrote:

> ACPI driver should make sure all the processor IDs in their ACPI Namespace
> are unique for CPU hotplug. the driver performs a depth-first walk of the
> namespace tree and calls the acpi_processor_ids_walk().
>
> But, the acpi_processor_ids_walk() will return true if one processor is
> checked, that cause the walk break after walking pass the first processor.
>
> Repace the value with AE_OK which is the standard acpi_status value.
>
> Fixes 8c8cb30f49b8 ("acpi/processor: Implement DEVICE operator for processor enumeration")
>
> Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
> ---
> drivers/acpi/acpi_processor.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c
> index 449d86d39965..db5bdb59639c 100644
> --- a/drivers/acpi/acpi_processor.c
> +++ b/drivers/acpi/acpi_processor.c
> @@ -663,11 +663,11 @@ static acpi_status __init acpi_processor_ids_walk(acpi_handle handle,
> }
>
> processor_validated_ids_update(uid);
> - return true;
> + return AE_OK;
>
> err:
> acpi_handle_info(handle, "Invalid processor object\n");
> - return false;
> + return AE_OK;

I'm not sure whether this is the right return value here. Rafael?

Thanks,

tglx

\
 
 \ /
  Last update: 2018-05-19 17:07    [W:0.103 / U:13.884 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site