lkml.org 
[lkml]   [2018]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v3] scripts/tags.sh: don't parse `ls` for $ALLSOURCE_ARCHS generation
2018-05-18 18:58 GMT+09:00 Joey Pabalinas <joeypabalinas@gmail.com>:
> On Fri, May 18, 2018 at 06:52:48PM +0900, Masahiro Yamada wrote:
>> Why is 'paste' necessary?
>
> Without it newlines from find are retained from the find
> output (at least in bash when I tested it). Though it doesn't
> really matter here since we are feeding it to a for loop, I
> just wanted to be sure this didn't surprise someone in the
> future by squeezing the newlines into spaces.
>

Hmm, I would personally get upset about that code.


Does this work?
ALLSOURCE_ARCHS=$(find "${tree}"arch -mindepth 1 -maxdepth 1 -type d
-printf ' %f')

It would leave one leading space, but I do not think it is a big deal.


It would be possible to chop it like follows, but I wonder if it is worth doing.
ALLSOURCE_ARCHS=$(find "${tree}"arch -mindepth 1 -maxdepth 1 -type d
-printf ' %f' | cut -c2-)


> --
> Cheers,
> Joey Pabalinas



--
Best Regards
Masahiro Yamada

\
 
 \ /
  Last update: 2018-05-18 13:04    [W:0.042 / U:0.176 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site