Messages in this thread | | | From | Masahiro Yamada <> | Date | Fri, 18 May 2018 18:52:48 +0900 | Subject | Re: [PATCH v3] scripts/tags.sh: don't parse `ls` for $ALLSOURCE_ARCHS generation |
| |
2018-05-18 18:31 GMT+09:00 Joey Pabalinas <joeypabalinas@gmail.com>: > On Fri, May 18, 2018 at 04:08:44PM +0900, Masahiro Yamada wrote: >> I do not like hard-coding the file(s) in arch/. >> >> Don't you have an idea to list only directories? >> 'find -type d' or 'ls -F' or something? > > How do you feel about the following? > >> # Detect if ALLSOURCE_ARCHS is set. If not, we assume SRCARCH >> if [ "${ALLSOURCE_ARCHS}" = "" ]; then >> ALLSOURCE_ARCHS="${SRCARCH}" >> elif [ "${ALLSOURCE_ARCHS}" = "all" ]; then >> ALLSOURCE_ARCHS="$(cd "${tree}arch/" && find . -maxdepth 1 -type d | paste -sd' ')"
Why is 'paste' necessary?
>> ALLSOURCE_ARCHS="${ALLSOURCE_ARCHS//[.\/]}" >> fi > > If something like that if acceptable, I'll use that for the v4. > > -- > Cheers, > Joey Pabalinas
-- Best Regards Masahiro Yamada
| |