Messages in this thread | | | Subject | Re: [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME | From | Joe Perches <> | Date | Fri, 18 May 2018 02:10:02 -0700 |
| |
On Fri, 2018-05-18 at 10:42 +0200, Petr Mladek wrote: > On Thu 2018-05-10 08:45:29, Joe Perches wrote: > > There are more than 1000 uses of #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > Make that the default define so these uses can be removed later via script. > > > > Signed-off-by: Joe Perches <joe@perches.com> > > It removes a lot of duplicates. I just hope that we will not need to > add the same amount of defines to remove/change the prefix where the > new default would look ugly.
I expect there will be far far fewer additions, perhaps a few dozen, than the about 1200 removals.
> I am not completely convinced that it is worth it. But it makes some > sense. Feel free to use: > > Acked-by: Petr Mladek <pmladek@suse.com> > > > BTW: I tried the entire patchset and there are still many locations > even in the boot log that might need an update:
Thanks.
> [ 0.000000] generic: MTRR default type: write-back
generic might be removed.
> [ 0.000000] libftrace: ftrace: allocating 40753 entries in 160 pages > [ 0.004008] apic: APIC: Switch to symmetric I/O mode setup
I believe the uppercase APIC: bit should be removed.
> [ 0.796479] workingset: workingset: timestamp_bits=36 max_order=20 bucket_order=0
and I will submit patches for these other duplicates.
> [ 1.044458] ipmi_si: ipmi_si: Unable to find any System Interface(s) > [ 1.046489] ioatdma: ioatdma: Intel(R) QuickData Technology Driver 4.00 > [ 1.076080] ppdev: ppdev: user-space parallel port driver > [ 1.484645] ehci_pci: ehci-pci: EHCI PCI platform driver > [ 1.544643] parport: parport0: cannot grant exclusive access for device pps_parport > [ 1.556821] usbcore: usbcore: registered new interface driver usbhid > [ 1.558001] usbhid: usbhid: USB HID core driver
cheers, Joe
| |