lkml.org 
[lkml]   [2018]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 2/6] mfd: at91-usart: added mfd driver for usart
    On Fri, May 11, 2018 at 01:38:18PM +0300, Radu Pirea wrote:
    > This mfd driver is just a wrapper over atmel_serial driver and
    > spi-at91-usart driver. Selection of one of the drivers is based on a
    > property from device tree. If the property is not specified, the default
    > driver is atmel_serial.
    >
    > Signed-off-by: Radu Pirea <radu.pirea@microchip.com>
    > ---
    > drivers/mfd/Kconfig | 10 ++++
    > drivers/mfd/Makefile | 1 +
    > drivers/mfd/at91-usart.c | 75 ++++++++++++++++++++++++++++
    > include/dt-bindings/mfd/at91-usart.h | 17 +++++++
    > 4 files changed, 103 insertions(+)
    > create mode 100644 drivers/mfd/at91-usart.c
    > create mode 100644 include/dt-bindings/mfd/at91-usart.h
    >

    > +#ifndef __DT_BINDINGS_AT91_USART_H__
    > +#define __DT_BINDINGS_AT91_USART_H__
    > +
    > +#define AT91_USART_MODE_SERIAL 1
    > +#define AT91_USART_MODE_SPI 2

    Won't this require a DT update for serial mode to add the mode property?
    That breaks compatibility.

    Rob

    \
     
     \ /
      Last update: 2018-05-19 00:20    [W:5.357 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site