Messages in this thread | | | From | Andy Shevchenko <> | Date | Fri, 18 May 2018 23:41:25 +0300 | Subject | Re: [PATCH v4] PCI: kirin: Add MSI support |
| |
On Thu, May 17, 2018 at 8:46 PM, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> wrote: > On Wed, May 16, 2018 at 09:21:59AM +0800, Xiaowei Song wrote:
>> +static void kirin_pcie_msi_init(struct pcie_port *pp) >> +{ >> + dw_pcie_msi_init(pp); >> +} >> + >> +static void kirin_pcie_enable_interrupts(struct pcie_port *pp) >> +{ >> + if (IS_ENABLED(CONFIG_PCI_MSI)) >> + kirin_pcie_msi_init(pp); >> +} > > Why do you need two functons ?
It's probably misreading of my suggestion which is more clearly can look like
if (!IS_ENABLED(CONFIG_PCI_MSI)) return; dw_pcie_msi_init(pp);
-- With Best Regards, Andy Shevchenko
| |