lkml.org 
[lkml]   [2018]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCHv8] gpio: Remove VLA from gpiolib
On Fri, May 18, 2018 at 8:53 PM, Laura Abbott <labbott@redhat.com> wrote:
> The new challenge is to remove VLAs from the kernel
> (see https://lkml.org/lkml/2018/3/7/621) to eventually
> turn on -Wvla.
>
> Using a kmalloc array is the easy way to fix this but kmalloc is still
> more expensive than stack allocation. Introduce a fast path with a
> fixed size stack array to cover most chip with gpios below some fixed
> amount. The slow path dynamically allocates an array to cover those
> chips with a large number of gpios.

> + unsigned long fastpath[2 * BITS_TO_LONGS(FASTPATH_NGPIO)];
> + unsigned long *mask, *bits;
> int first, j, ret;
>
> + if (likely(chip->ngpio <= FASTPATH_NGPIO)) {
> + mask = fastpath;
> + } else {
> + mask = kmalloc_array(2 * BITS_TO_LONGS(chip->ngpio),
> + sizeof(*mask),
> + can_sleep ? GFP_KERNEL : GFP_ATOMIC);
> + if (!mask)
> + return -ENOMEM;
> + }
> +
> + bits = mask + BITS_TO_LONGS(chip->ngpio);
> + memset(mask, 0, BITS_TO_LONGS(chip->ngpio) * sizeof(*mask));

Wouldn't be better

bitmap_zero(mask, chip->ngpio);

?

> + bits = mask + BITS_TO_LONGS(chip->ngpio);
> + memset(mask, 0, BITS_TO_LONGS(chip->ngpio) * sizeof(*mask));

Ditto.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2018-05-18 22:07    [W:0.038 / U:27.672 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site