lkml.org 
[lkml]   [2018]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 2/3] perf report: Use perf_evlist_forced_leader to support '--group'
From
Date


On 5/18/2018 3:04 PM, Jiri Olsa wrote:
> On Fri, May 18, 2018 at 08:57:39PM +0800, Jin Yao wrote:
>> Since we have created a new function perf_evlist_forced_leader,
>> so now remove the old code and use perf_evlist_forced_leader
>> instead.
>>
>> Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
>> ---
>> tools/perf/builtin-report.c | 8 ++------
>> 1 file changed, 2 insertions(+), 6 deletions(-)
>>
>> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
>> index 4c931af..63fe776 100644
>> --- a/tools/perf/builtin-report.c
>> +++ b/tools/perf/builtin-report.c
>> @@ -202,12 +202,8 @@ static int hist_iter__branch_callback(struct hist_entry_iter *iter,
>
> there's comment in this place, which no longer applies in here:
>
>
> /*
> * Events in data file are not collect in groups, but we still want
> * the group display. Set the artificial group and set the leader's
> * forced_leader flag to notify the display code.
> */
>
> could you please move/change/apply it to perf_evlist_forced_leader
>
> thanks,
> jirka
>

Oh, yes, I should move the comment to perf_evlist_forced_leader.

I will do it in next version.

Thanks
Jin Yao

>> static void setup_forced_leader(struct report *report,
>> struct perf_evlist *evlist)
>
>> {
>> - if (report->group_set && !evlist->nr_groups) {
>> - struct perf_evsel *leader = perf_evlist__first(evlist);
>> -
>> - perf_evlist__set_leader(evlist);
>> - leader->forced_leader = true;
>> - }
>> + if (report->group_set)
>> + perf_evlist_forced_leader(evlist);
>> }
>>
>> static int process_feature_event(struct perf_tool *tool,
>> --
>> 2.7.4
>>

\
 
 \ /
  Last update: 2018-05-18 09:22    [W:0.033 / U:18.592 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site