lkml.org 
[lkml]   [2018]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC v3 PATCH 1/5] mm/page_alloc: use helper functions to add/remove a page to/from buddy
On Thu, May 17, 2018 at 04:48:21AM -0700, Matthew Wilcox wrote:
> On Wed, May 09, 2018 at 04:54:46PM +0800, Aaron Lu wrote:
> > +static inline void add_to_buddy_head(struct page *page, struct zone *zone,
> > + unsigned int order, int mt)
> > +{
> > + add_to_buddy_common(page, zone, order);
> > + list_add(&page->lru, &zone->free_area[order].free_list[mt]);
> > +}
>
> Isn't this function (and all of its friends) misnamed? We're not adding
> this page to the buddy allocator, we're adding it to the freelist. It
> doesn't go to the buddy allocator until later, if at all.

No, never mind, I misunderstood. Ignore this please.

\
 
 \ /
  Last update: 2018-05-17 13:54    [W:1.190 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site