lkml.org 
[lkml]   [2018]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 3/3] serial: 8250_port: Disable DMA operations for kernel console
On 2018-05-15 21:34:09 [+0300], Andy Shevchenko wrote:
> It will be too tricky and error prone to allow DMA operations on kernel
> console.

Why is it tricky and error prone? I had it working…
But I don't mind dropping the DMA on the kernel console because I doubt
that we lose something here by disabling it. I would even imagine that
it gets "simpler" (maybe what you tried to say by "error prone") to
print something in the NMI case by writing directly to the FIFO register
instead setting up a DMA transfer and so on.

> Disable any kind of DMA operations in such case.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/tty/serial/8250/8250_port.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c
> index db97222a1bf4..9a4696ea728b 100644
> --- a/drivers/tty/serial/8250/8250_port.c
> +++ b/drivers/tty/serial/8250/8250_port.c
> @@ -2371,7 +2371,10 @@ int serial8250_do_startup(struct uart_port *port)
> * Request DMA channels for both RX and TX.
> */
> if (up->dma) {
> - retval = serial8250_request_dma(up);
> + if (uart_console(port))
> + retval = -ENXIO;
> + else
> + retval = serial8250_request_dma(up);
> if (retval)
> pr_warn_ratelimited("ttyS%d - failed to request DMA\n",
> serial_index(port));

I would appreciate if you note that it is disabled on purpose and not
because something failed.
Other than those minor things I an board :)

> --
> 2.17.0

Sebastian

\
 
 \ /
  Last update: 2018-05-16 12:56    [W:0.065 / U:2.472 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site