lkml.org 
[lkml]   [2018]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 34/40] atm: simplify procfs code
Christoph Hellwig <hch@lst.de> writes:

> On Sat, May 05, 2018 at 07:51:18AM -0500, Eric W. Biederman wrote:
>> Christoph Hellwig <hch@lst.de> writes:
>>
>> > Use remove_proc_subtree to remove the whole subtree on cleanup, and
>> > unwind the registration loop into individual calls. Switch to use
>> > proc_create_seq where applicable.
>>
>> Can you please explain why you are removing the error handling when
>> you are unwinding the registration loop?
>
> Because there is no point in handling these errors. The code work
> perfectly fine without procfs, or without given proc files and the
> removal works just fine if they don't exist either. This is a very
> common patter in various parts of the kernel already.
>
> I'll document it better in the changelog.

Thank you. That is the kind of thing that could be a signal of
inattentiveness and problems, especially when it is not documented.

Eric

\
 
 \ /
  Last update: 2018-05-17 03:16    [W:0.084 / U:4.120 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site