Messages in this thread | | | Subject | Re: [PATCH V2] mlx4_core: allocate ICM memory in page size chunks | From | Eric Dumazet <> | Date | Tue, 15 May 2018 12:08:01 -0700 |
| |
On 05/15/2018 11:53 AM, Qing Huang wrote: > >> This is control path so it is less latency-sensitive. >> Let's not produce unnecessary degradation here, please call kvzalloc so we maintain a similar behavior when contiguous memory is available, and a fallback for resiliency. > > No sure what exactly degradation is caused by vzalloc here. I think it's better to keep physically contiguous pages > to other requests which really need them. Besides slow path/mem compacting can be really expensive. >
Just use kvzalloc(), and you get the benefit of having contiguous memory if available, without expensive compact phase.
This thing _automatically_ falls back to vmalloc(), thus your problem will be solved.
If you are not sure, trust others.
| |