Messages in this thread | | | Subject | Re: [PATCH 1/2] phy: qcom-qmp: Quiet -EPROBE_DEFER from qcom_qmp_phy_probe() | From | Vivek Gautam <> | Date | Tue, 15 May 2018 12:32:14 +0530 |
| |
Hi Doug,
On 5/15/2018 4:12 AM, Douglas Anderson wrote: > The -EPROBE_DEFER virus demands special case code to avoid printing > error messages when the error is only -EPROBE_DEFER. Spread the virus > to a new host: qcom_qmp_phy_probe(). Specifically handle when our > regulators might not be ready yet. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > > drivers/phy/qualcomm/phy-qcom-qmp.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c > index 6470c5d61d1c..a740daa58b31 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c > @@ -1447,7 +1447,9 @@ static int qcom_qmp_phy_probe(struct platform_device *pdev) > > ret = qcom_qmp_phy_vreg_init(dev); > if (ret) { > - dev_err(dev, "failed to get regulator supplies\n"); > + if (ret != -EPROBE_DEFER) > + dev_err(dev, "failed to get regulator supplies: %d\n", > + ret); > return ret; > } >
Thanks for the patch. Looks good to me. Reviewed-by: Vivek Gautam <vivek.gautam@codeaurora.org>
regards Vivek
| |