Messages in this thread | | | From | Linus Walleij <> | Date | Mon, 14 May 2018 08:04:12 +0200 | Subject | Re: [PATCH 05/18 v2] regulator: max77686: Pass descriptor instead of GPIO number |
| |
On Mon, Apr 23, 2018 at 8:46 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> Both my previous comments remain not addressed: > 1. Name: This is also for bucks so how about naming it "max77686-regulator"? > 2. Error path here is not equivalent to old code and results in using > default driver's init data. Instead I would prefer to just ignore the > gpio.
Sorry for missing these :(
I fixed it up for v3.
Yours, Linus Walleij
| |