lkml.org 
[lkml]   [2018]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 05/18 v2] regulator: max77686: Pass descriptor instead of GPIO number
On Mon, Apr 23, 2018 at 8:46 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote:

> Both my previous comments remain not addressed:
> 1. Name: This is also for bucks so how about naming it "max77686-regulator"?
> 2. Error path here is not equivalent to old code and results in using
> default driver's init data. Instead I would prefer to just ignore the
> gpio.

Sorry for missing these :(

I fixed it up for v3.

Yours,
Linus Walleij

\
 
 \ /
  Last update: 2018-05-14 08:05    [W:0.202 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site