lkml.org 
[lkml]   [2018]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] MIPS: memset.S: EVA & fault support for small_memset
On Mon, 16 Apr 2018, James Hogan wrote:

> > @@ -260,6 +260,11 @@
> > jr ra
> > andi v1, a2, STORMASK
>
> This patch looks good, well spotted!
>
> But whats that v1 write about? Any ideas? Seems to go back to the git
> epoch, and $3 isn't in the clobber lists when __bzero* is called.

You need to dive deeper, that is beyond the secret commit 66f0a432564b
("Add resource managment."), to find what's happened before the epoch. ;)

Anyway, there isn't anything special here, the thing has been here since
the inception of memset.S with commit 2e0f55e79c49 (no shortlog available
for that one). And it is clearly a bug, possibly just a leftover from a
WIP implementation or whatever.

And I can see Matt has already fixed that, thanks!

Maciej

\
 
 \ /
  Last update: 2018-05-15 01:11    [W:5.528 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site