lkml.org 
[lkml]   [2018]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 1/1] Drivers: hv: vmbus: enable VMBus protocol version 5.0
Date
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Monday, May 14, 2018 11:18
> To: Dexuan Cui <decui@microsoft.com>
> > > ...
> > > Hate to pick o the details, but buffer is void * so cast is not necessary here.
> >
> > Yes, it's unnecessary in C, though it's necessary in C++.
> >
> > I found the patch went into char-misc 4 hours ago, so it looks we may
> > as well leave it as is. IMHO an explicit cast is not a bad thing. :-)
> >
> > Thanks,
> > -- Dexuan
>
> Kernel developers like to be concise. In fact there is a smatch script that
> perodically gets run and more cleanup patches get sent.

I checked the "git log" and confimed you're correct: there are a lot of
patches that removed the cast from "void *". :-)

Then let me post a small patch for this.

-- Dexuan


\
 
 \ /
  Last update: 2018-05-14 20:57    [W:0.080 / U:0.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site