lkml.org 
[lkml]   [2018]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] gpu: drm: tegra: Adding new typedef vm_fault_t
On Mon, Apr 23, 2018 at 4:24 PM, Matthew Wilcox <willy@infradead.org> wrote:
> On Wed, Apr 18, 2018 at 10:24:39AM +0200, Thierry Reding wrote:
>> > @@ -437,20 +436,7 @@ static int tegra_bo_fault(struct vm_fault *vmf)
>> > offset = (vmf->address - vma->vm_start) >> PAGE_SHIFT;
>> > page = bo->pages[offset];
>> >
>> > - err = vm_insert_page(vma, vmf->address, page);
>> > - switch (err) {
>> > - case -EAGAIN:
>> > - case 0:
>> > - case -ERESTARTSYS:
>> > - case -EINTR:
>> > - case -EBUSY:
>> > - return VM_FAULT_NOPAGE;
>> > -
>> > - case -ENOMEM:
>> > - return VM_FAULT_OOM;
>> > - }
>> > -
>> > - return VM_FAULT_SIGBUS;
>> > + return vmf_insert_page(vma, vmf->address, page);
>> > }
>>
>> This new function returns VM_FAULT_NOPAGE only for 0 and -EBUSY, whereas
>> we used to return VM_FAULT_NOPAGE for -EAGAIN, -ERESTARTSYS and -EINTR
>> as well. Was this previously wrong?
>
> Not so much wrong as unnecessary. vm_insert_page() can't return -EAGAIN,
> -ERESTARTSYS or -EINTR.

If no further comment on this patch, We would like to get this patch
queued for 4.18.

\
 
 \ /
  Last update: 2018-05-11 20:21    [W:0.038 / U:7.200 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site