lkml.org 
[lkml]   [2018]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH][ocfs2-next] ocfs2: remove redundant check that tmp_oh is not null
    Date
    From: Colin Ian King <colin.king@canonical.com>

    There is an earlier check and return if tmp_oh is null, hence the
    finaly check to see if it is not null is redundant and can be
    replaced with return 1 instead.

    Detected by CoverityScan, CIK#1468855 ("Logically dead code")

    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    ---
    fs/ocfs2/dlmglue.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c
    index e0a1574314e1..c34fd27a41f3 100644
    --- a/fs/ocfs2/dlmglue.c
    +++ b/fs/ocfs2/dlmglue.c
    @@ -2695,7 +2695,7 @@ int ocfs2_inode_lock_tracker(struct inode *inode,
    return status;
    }
    }
    - return tmp_oh ? 1 : 0;
    + return 1;
    }

    void ocfs2_inode_unlock_tracker(struct inode *inode,
    --
    2.17.0
    \
     
     \ /
      Last update: 2018-05-11 16:05    [W:5.557 / U:0.452 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site