Messages in this thread | | | Subject | Re: [PATCH v2 2/2] soc: mediatek: reuse regmap_read_poll_timeout helpers | From | Matthias Brugger <> | Date | Fri, 11 May 2018 13:25:02 +0200 |
| |
Hi Sean,
On 04/23/2018 08:42 AM, sean.wang@mediatek.com wrote: > From: Sean Wang <sean.wang@mediatek.com> > > Reuse the common helpers regmap_read_poll_timeout provided by Linux core > instead of an open-coded handling. > > v1 -> v2: > - use macro definitions MTK_POLL_DELAY_US and MTK_POLL_TIMEOUT for > arguments sleep_us and timeout_us passing in regmap_read_poll_timeout. > - remove unnecessary linux/iopoll.h being included in. >
I just realized that you wrote the changelog here, which will make it show up in the commit log. Thant's not what we want... (see below)
> Signed-off-by: Sean Wang <sean.wang@mediatek.com> > Cc: Matthias Brugger <matthias.bgg@gmail.com> > Cc: Ulf Hansson <ulf.hansson@linaro.org> > Cc: Weiyi Lu <weiyi.lu@mediatek.com> > --- > drivers/soc/mediatek/mtk-infracfg.c | 46 ++++++++++--------------------------- > 1 file changed, 12 insertions(+), 34 deletions(-) >
Please write your changelog here in the future. I'll fix that up in my tree now, but please remember the next time :) Thanks Matthias
| |