Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH 4.17 2/2] ssb: make SSB_PCICORE_HOSTMODE depend on SSB = y | Date | Fri, 11 May 2018 13:18:30 +0300 |
| |
Larry Finger <Larry.Finger@lwfinger.net> writes:
> On 05/10/2018 06:14 AM, Rafał Miłecki wrote: >> From: Rafał Miłecki <rafal@milecki.pl> >> >> SSB_PCICORE_HOSTMODE protects MIPS specific code that calls not exported >> symbols pcibios_enable_device and register_pci_controller. This code is >> supposed to be compiled only with ssb builtin. >> >> This fixes: >> ERROR: "pcibios_enable_device" [drivers/ssb/ssb.ko] undefined! >> ERROR: "register_pci_controller" [drivers/ssb/ssb.ko] undefined! >> make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1 >> >> Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > > This patch needs a "Reported-by: Matt Redfearn <matt.redfearn@mips.com>". > > Applying both patches leads to a correct configuration for PCI. I > cannot test on my present hardware, but the patches seem to be > correct. > > Reviewed-by: Larry Finger <Larry.Finger@lwfinger.net> > > @Kalle: Please drop my patch from yesterday. This solution is much better.
Dropped, thanks for letting me know.
-- Kalle Valo
| |