Messages in this thread | | | Date | Fri, 11 May 2018 09:42:19 +0100 | From | Patrick Bellasi <> | Subject | Re: [PATCH 3/3] sched/fair: schedutil: explicit update only when required |
| |
On 11-May 11:13, Viresh Kumar wrote: > On 10-05-18, 16:05, Patrick Bellasi wrote: > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > > -static void attach_entity_load_avg(struct cfs_rq *cfs_rq, struct sched_entity *se, int flags) > > +static void attach_entity_load_avg(struct cfs_rq *cfs_rq, struct sched_entity *se) > > { > > u32 divider = LOAD_AVG_MAX - 1024 + cfs_rq->avg.period_contrib; > > > > @@ -3762,7 +3736,6 @@ static void attach_entity_load_avg(struct cfs_rq *cfs_rq, struct sched_entity *s > > > > add_tg_cfs_propagate(cfs_rq, se->avg.load_sum); > > > > - cfs_rq_util_change(cfs_rq, flags); > > Was leaving a blank line at the end of routine intentional ?
No, good catch. Will fix this, thanks!
> > > } > > > > /** > > @@ -3781,7 +3754,6 @@ static void detach_entity_load_avg(struct cfs_rq *cfs_rq, struct sched_entity *s > > > > add_tg_cfs_propagate(cfs_rq, -se->avg.load_sum); > > > > - cfs_rq_util_change(cfs_rq, 0); > > Here too. > > > } > -- > viresh
-- #include <best/regards.h>
Patrick Bellasi
| |