lkml.org 
[lkml]   [2018]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/2] i2c: exynos5: remove some dead code
    From
    Date
    On 09.05.2018 21:45, Peter Rosin wrote:
    > The else branch cannot be taken as i will always equal num.
    > Get rid of the whole construct.
    >
    > Signed-off-by: Peter Rosin <peda@axentia.se>
    > ---
    > drivers/i2c/busses/i2c-exynos5.c | 12 +-----------
    > 1 file changed, 1 insertion(+), 11 deletions(-)
    >
    > diff --git a/drivers/i2c/busses/i2c-exynos5.c b/drivers/i2c/busses/i2c-exynos5.c
    > index 12ec8484e653..a2cbc779c33a 100644
    > --- a/drivers/i2c/busses/i2c-exynos5.c
    > +++ b/drivers/i2c/busses/i2c-exynos5.c
    > @@ -727,17 +727,7 @@ static int exynos5_i2c_xfer(struct i2c_adapter *adap,
    > goto out;
    > }
    >
    > - if (i == num) {
    > - ret = num;
    > - } else {
    > - /* Only one message, cannot access the device */
    > - if (i == 1)
    > - ret = -EREMOTEIO;
    > - else
    > - ret = i;
    > -
    > - dev_warn(i2c->dev, "xfer message failed\n");
    > - }
    > + ret = num;
    >
    > out:
    > clk_disable(i2c->clk);

    You can go further and remove "out:" label, use break instead, and at
    the end use "return (i == num) ? num : ret;" or sth similar.

    With this change you can add:

    Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>

     --
    Regards
    Andrzej


    \
     
     \ /
      Last update: 2018-05-10 10:37    [W:3.421 / U:0.280 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site