Messages in this thread | | | Date | Tue, 1 May 2018 15:49:20 -0700 | From | Dmitry Torokhov <> | Subject | Re: [PATCH v2] Input: atmel_mxt_ts - add missing compatible strings to OF device table |
| |
On Tue, May 01, 2018 at 04:33:07PM -0500, Rob Herring wrote: > On Tue, May 1, 2018 at 3:57 PM, Dmitry Torokhov > <dmitry.torokhov@gmail.com> wrote: > > From: Javier Martinez Canillas <javierm@redhat.com> > > > > Commit af503716ac14 ("i2c: core: report OF style module alias for devices > > registered via OF") fixed how the I2C core reports the module alias when > > devices are registered via OF. > > > > But the atmel_mxt_ts driver only has an "atmel,maxtouch" compatible in its > > OF device ID table, so if a Device Tree is using a different one, autoload > > won't be working for the module (the matching works because the I2C device > > ID table is used as a fallback). > > > > So add compatible strings for each of the entries in the I2C device table. > > > > Fixes: af503716ac14 ("i2c: core: report OF style module alias for devices registered via OF") > > Reported-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> > > Tested-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > > [dtor: document which compatibles are deprecated and should not be used] > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > --- > > .../devicetree/bindings/input/atmel,maxtouch.txt | 7 +++++++ > > drivers/input/touchscreen/atmel_mxt_ts.c | 5 +++++ > > 2 files changed, 12 insertions(+) > > Reviewed-by: Rob Herring <robh@kernel.org> > > Someone is going to make the dts updates, right?
I sent out 2 patches...
-- Dmitry
| |