Messages in this thread | | | Date | Mon, 9 Apr 2018 10:53:56 -0400 | From | Jerome Glisse <> | Subject | Re: [PATCH 0/3] move __HAVE_ARCH_PTE_SPECIAL in Kconfig |
| |
On Mon, Apr 09, 2018 at 04:07:21PM +0200, Michal Hocko wrote: > On Mon 09-04-18 15:57:06, Laurent Dufour wrote: > > The per architecture __HAVE_ARCH_PTE_SPECIAL is defined statically in the > > per architecture header files. This doesn't allow to make other > > configuration dependent on it. > > > > This series is moving the __HAVE_ARCH_PTE_SPECIAL into the Kconfig files, > > setting it automatically when architectures was already setting it in > > header file. > > > > There is no functional change introduced by this series. > > I would just fold all three patches into a single one. It is much easier > to review that those selects are done properly when you can see that the > define is set for the same architecture. > > In general, I like the patch. It is always quite painful to track per > arch defines.
You can also add Reviewed-by: Jérôme Glisse <jglisse@redhat> my grep fu showed no place that was forgotten.
Cheers, Jérôme
| |