lkml.org 
[lkml]   [2018]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 4.4 083/162] libertas: Fix lbs_prb_rsp_limit_set()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 69551f5f370cc20342fab17ca54716b6ec7e332d ]

    The kstrtoul() test was reversed so this always returned -ENOTSUPP.

    Fixes: 27d7f47756f4 ("net: wireless: replace strict_strtoul() with kstrtoul()")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Reviewed-by: James Cameron <quozl@laptop.org>
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    drivers/net/wireless/libertas/mesh.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/wireless/libertas/mesh.c b/drivers/net/wireless/libertas/mesh.c
    index d0c881dd5846..a78c4d18fe4b 100644
    --- a/drivers/net/wireless/libertas/mesh.c
    +++ b/drivers/net/wireless/libertas/mesh.c
    @@ -239,8 +239,9 @@ static ssize_t lbs_prb_rsp_limit_set(struct device *dev,
    memset(&mesh_access, 0, sizeof(mesh_access));
    mesh_access.data[0] = cpu_to_le32(CMD_ACT_SET);

    - if (!kstrtoul(buf, 10, &retry_limit))
    - return -ENOTSUPP;
    + ret = kstrtoul(buf, 10, &retry_limit);
    + if (ret)
    + return ret;
    if (retry_limit > 15)
    return -ENOTSUPP;

    --
    2.15.1
    \
     
     \ /
      Last update: 2018-04-09 02:38    [W:4.030 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site