lkml.org 
[lkml]   [2018]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 07/91] random: fix possible sleeping allocation from irq context
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Theodore Ts'o <tytso@mit.edu>

    commit 6c1e851c4edc13a43adb3ea4044e3fc8f43ccf7d upstream.

    We can do a sleeping allocation from an irq context when CONFIG_NUMA
    is enabled. Fix this by initializing the NUMA crng instances in a
    workqueue.

    Reported-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
    Reported-by: syzbot+9de458f6a5e713ee8c1a@syzkaller.appspotmail.com
    Fixes: 8ef35c866f8862df ("random: set up the NUMA crng instances...")
    Cc: stable@vger.kernel.org
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/char/random.c | 9 ++++++++-
    1 file changed, 8 insertions(+), 1 deletion(-)

    --- a/drivers/char/random.c
    +++ b/drivers/char/random.c
    @@ -788,7 +788,7 @@ static void crng_initialize(struct crng_
    }

    #ifdef CONFIG_NUMA
    -static void numa_crng_init(void)
    +static void do_numa_crng_init(struct work_struct *work)
    {
    int i;
    struct crng_state *crng;
    @@ -809,6 +809,13 @@ static void numa_crng_init(void)
    kfree(pool);
    }
    }
    +
    +static DECLARE_WORK(numa_crng_init_work, do_numa_crng_init);
    +
    +static void numa_crng_init(void)
    +{
    + schedule_work(&numa_crng_init_work);
    +}
    #else
    static void numa_crng_init(void) {}
    #endif

    \
     
     \ /
      Last update: 2018-04-30 22:14    [W:4.294 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site