lkml.org 
[lkml]   [2018]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 35/91] ALSA: dice: fix error path to destroy initialized stream data
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Takashi Sakamoto <o-takashi@sakamocchi.jp>

    commit 0f925660a7bc49b269c163249a5d06da3a0c7b0a upstream.

    In error path of snd_dice_stream_init_duplex(), stream data for incoming
    packet can be left to be initialized.

    This commit fixes it.

    Fixes: 436b5abe2224 ('ALSA: dice: handle whole available isochronous streams')
    Cc: <stable@vger.kernel.org> # v4.6+
    Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/firewire/dice/dice-stream.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/sound/firewire/dice/dice-stream.c
    +++ b/sound/firewire/dice/dice-stream.c
    @@ -435,7 +435,7 @@ int snd_dice_stream_init_duplex(struct s
    err = init_stream(dice, AMDTP_IN_STREAM, i);
    if (err < 0) {
    for (; i >= 0; i--)
    - destroy_stream(dice, AMDTP_OUT_STREAM, i);
    + destroy_stream(dice, AMDTP_IN_STREAM, i);
    goto end;
    }
    }

    \
     
     \ /
      Last update: 2018-04-30 22:13    [W:3.705 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site