lkml.org 
[lkml]   [2018]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 76/91] fpga-manager: altera-ps-spi: preserve nCONFIG state
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Anatolij Gustschin <agust@denx.de>

    commit 881c93c0fb73328845898344208fa0bf0d62cac6 upstream.

    If the driver module is loaded when FPGA is configured, the FPGA
    is reset because nconfig is pulled low (low-active gpio inited
    with GPIOD_OUT_HIGH activates the signal which means setting its
    value to low). Init nconfig with GPIOD_OUT_LOW to prevent this.

    Signed-off-by: Anatolij Gustschin <agust@denx.de>
    Acked-by: Alan Tull <atull@kernel.org>
    Signed-off-by: Moritz Fischer <mdf@kernel.org>
    Cc: stable <stable@vger.kernel.org> # 4.14+
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/fpga/altera-ps-spi.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/fpga/altera-ps-spi.c
    +++ b/drivers/fpga/altera-ps-spi.c
    @@ -249,7 +249,7 @@ static int altera_ps_probe(struct spi_de

    conf->data = of_id->data;
    conf->spi = spi;
    - conf->config = devm_gpiod_get(&spi->dev, "nconfig", GPIOD_OUT_HIGH);
    + conf->config = devm_gpiod_get(&spi->dev, "nconfig", GPIOD_OUT_LOW);
    if (IS_ERR(conf->config)) {
    dev_err(&spi->dev, "Failed to get config gpio: %ld\n",
    PTR_ERR(conf->config));

    \
     
     \ /
      Last update: 2018-04-30 22:03    [W:6.334 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site