Messages in this thread | | | Subject | Re: [PATCH][next] media: ispstat: don't dereference user_cfg before a null check | From | "Gustavo A. R. Silva" <> | Date | Mon, 30 Apr 2018 10:26:25 -0500 |
| |
Hi Sakari,
On 04/30/2018 10:15 AM, Sakari Ailus wrote: >> Isn't there a guarantee that new_buf won't be NULL ? The new_buf pointer comes >> from the parg variable in video_usercopy(), which should always point to a >> valid buffer given that the ioctl number specifies a non-zero size. > > Fair question. After looking at the code, I agree with you; there should be > no reason to perform the check in the first place. It may have been that > the function has been used differently in the past but the check should be > rather removed now. > > I'll drop the patch. >
Please, if the check isn't needed anymore, make sure it is removed.
This helps to reduce the number of false positives reported by static analyzers.
Thanks -- Gustavo
| |