lkml.org 
[lkml]   [2018]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 01/18] thermal: exynos: fix setting rising_threshold for Exynos5433
    On Thu, Apr 26, 2018 at 01:51:16PM +0200, Bartlomiej Zolnierkiewicz wrote:
    > Add missing clearing of the previous value when setting rising
    > temperature threshold.
    >
    > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
    > ---
    > drivers/thermal/samsung/exynos_tmu.c | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
    > index cda716c..523d26e 100644
    > --- a/drivers/thermal/samsung/exynos_tmu.c
    > +++ b/drivers/thermal/samsung/exynos_tmu.c
    > @@ -577,6 +577,7 @@ static int exynos5433_tmu_initialize(struct platform_device *pdev)
    > threshold_code = temp_to_code(data, temp);
    >
    > rising_threshold = readl(data->base + rising_reg_offset);
    > + rising_threshold &= ~(0xff << j * 8);
    > rising_threshold |= (threshold_code << j * 8);

    Bartlomiej,

    I see this code is duplicated all around the driver, so I can't blame you to
    fix it in the same way it is written today but this is not how to deal with
    fields in a register mapping. Can you fix it by adding correct macros with
    masks?

    --

    <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

    Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
    <http://twitter.com/#!/linaroorg> Twitter |
    <http://www.linaro.org/linaro-blog/> Blog

    \
     
     \ /
      Last update: 2018-04-30 16:37    [W:4.115 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site