Messages in this thread | | | Date | Tue, 3 Apr 2018 16:52:02 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 1/1] taging: fbtft: fix memory leak |
| |
There is a typo in the subject. It should be "Staging" instead of "taging:".
On Tue, Apr 03, 2018 at 09:14:28PM +0800, Xidong Wang wrote: > From: Xidong Wang <2711406067@qq.com> > > In function fbtft_framebuffer_alloc(), the memory allocated by > framebuffer_alloc() is not released on the error path that txbuflen > 0 > and txbuf, which holds the return value of devm_kzalloc(), is NULL. > This will result in a memory leak bug.
The txbuf chunk seems to have been dropped. You're right that it needs to be fixed as well.
if (txbuflen > 0) { txbuf = devm_kzalloc(par->info->device, txbuflen, GFP_KERNEL); if (!txbuf) - goto alloc_fail; + goto err_info;
regards, dan carpenter
| |