lkml.org 
[lkml]   [2018]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 20/61] input: keyboard: simplify getting .drvdata
    Hi Dmitry,

    > > We should get drvdata from struct device directly. Going via
    > > platform_device is an unneeded step back and forth.
    >
    > I consider the fact that platform device's driver data is accessible via
    > device driver data being implementation detail that may or may not change

    Isn't it actually the other way around? platform_get_drvdata() is a
    convenience function to access driver_data which is embedded in struct
    device?

    > in the future, so I'd prefer keep using the proper accessors for the
    > objects we are dealing with.

    Exactly. I'd just argue, the object we are dealing with, declared in the
    PM functions, is a struct device.

    Thanks for the comment,

    Wolfram

    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2018-04-26 22:05    [W:3.555 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site