lkml.org 
[lkml]   [2018]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] nvme: change order of qid and cmdid in completion trace
From
Date
On 4/26/18 1:49 PM, Johannes Thumshirn wrote:
> Keith reported that command submission and command completion
> tracepoints have the order of the cmdid and qid fileds swapped.
>
> While it isn't easily possible to change the command submission
> tracepoint, as there is a regression test parsing it in blktests we
> can swap the command completion tracepoint to have the fileds aligned.

It also makes more sense to have qid before cmdid.

Also, fileds -> fields, in two spots.

With that:

Reviewed-by: Jens Axboe <axboe@kernel.dk>

--
Jens Axboe

\
 
 \ /
  Last update: 2018-04-26 22:03    [W:0.032 / U:2.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site