Messages in this thread | | | Subject | Re: [PATCH 1/2] net: can: sja1000: Replace mdelay with usleep_range in peak_pci_probe | From | Marc Kleine-Budde <> | Date | Wed, 25 Apr 2018 16:53:10 +0200 |
| |
On 04/11/2018 03:42 AM, Jia-Ju Bai wrote: > peak_pci_probe() is never called in atomic context. > > peak_pci_probe() is set as ".probe" in struct pci_driver. > > Despite never getting called from atomic context, peak_pci_probe() > calls mdelay() to busily wait. > This is not necessary and can be replaced with usleep_range() to > avoid busy waiting. > > This is found by a static analysis tool named DCNS written by myself. > And I also manually check it. > > Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Applied both to linux-can-next.
tnx, Marc
-- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[unhandled content-type:application/pgp-signature] | |