Messages in this thread | | | Subject | Re: [1/2] net: wireless: zydas: Replace mdelay with msleep in zd1201_probe | From | Kalle Valo <> | Date | Wed, 25 Apr 2018 08:15:23 +0000 (UTC) |
| |
Jia-Ju Bai <baijiaju1990@gmail.com> wrote:
> zd1201_probe() is never called in atomic context. > > zd1201_probe() is only set as ".probe" in struct usb_driver. > > Despite never getting called from atomic context, zd1201_probe() > calls mdelay() to busily wait. > This is not necessary and can be replaced with msleep() to > avoid busy waiting. > > This is found by a static analysis tool named DCNS written by myself. > And I also manually check it. > > Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
I need a review from someone else before I'm willing to take this.
-- https://patchwork.kernel.org/patch/10333189/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |