Messages in this thread | | | Date | Tue, 24 Apr 2018 18:23:30 +0100 | From | Jonathan Cameron <> | Subject | Re: [PATCH 1/2] iio: adc128s052: allow driver to be matched using ACPI |
| |
On Sat, 21 Apr 2018 21:41:57 +0100 Javier Arteaga <javier@emutex.com> wrote:
> Hi Jonathan, > > On Sat, Apr 21, 2018 at 04:54:41PM +0100, Jonathan Cameron wrote: > > I don't really see the connection between the change in here > > and what the description says... > > I think you're right, we didn't make our intent clear here. > > > If you are probing from ACPI then there is no need to ensure > > a valid of table is supplied (even if we aren't building with OF) > > which is what I think this patch is trying to do... > > The patch enables ACPI _DSD to reuse existing DT "compatible" strings, > as described in Documentation/acpi/enumeration.txt, even without OF. > This kind of patch has some precedent, like for example: > > 01427fe7c4b9 ("Input: adxl34x - make it enumerable in ACPI environment") > > To clarify, for the UP2 board we don't actually need this patch as we > have an ACPI _HID - just thought it would might be an improvement for > others. > > I'll improve the description and perhaps reorder this patch last for v2. > Or I can send separately if you prefer. > > Thanks for your review! Unless we know of ACPI firmwares out there that are doing this, drop the patch for now. I don't want to see a flood of these based on a 'you can do it that' way argument.
Jonathan
> -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
| |